Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weighted Delaunay triangulation #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kiranvad
Copy link

Hey,
I added a function to compute a weighted Delaunay triangulation (to Alpha filtration) which is a really useful tool for people working with molecules and alpha complexes.
The basic idea is to compute Delaunay triangulation using its duality with convex hull of one dimension above.
I am not sure if usage of a weighted Dealunay would require a change in the circumradius computation(think not). I also added a three line example in the BasicUsage.ipynb.

Have a look and let me know what you think.

@kiranvad kiranvad requested a review from sauln January 25, 2020 22:07
@codecov
Copy link

codecov bot commented Jan 25, 2020

Codecov Report

Merging #15 into master will decrease coverage by 3.18%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   92.91%   89.72%   -3.19%     
==========================================
  Files          12       12              
  Lines         381      399      +18     
==========================================
+ Hits          354      358       +4     
- Misses         27       41      +14
Impacted Files Coverage Δ
cechmate/filtrations/alpha.py 83.01% <33.33%> (-12.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93d0220...f7d518c. Read the comment docs.

@ctralie
Copy link
Member

ctralie commented Jan 26, 2020 via email

@ctralie ctralie self-assigned this Mar 11, 2020
@sauln
Copy link
Member

sauln commented Mar 2, 2021

@ctralie What is the status of this? do we still have work to do moving this PR forward?

@ctralie
Copy link
Member

ctralie commented Mar 2, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants